Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation script #23

Merged
merged 7 commits into from
Feb 7, 2019
Merged

Add installation script #23

merged 7 commits into from
Feb 7, 2019

Conversation

Schniz
Copy link
Owner

@Schniz Schniz commented Feb 5, 2019

A work in progress.
Not sure if I'd like to cover it with a "feature" test too

Can be a great workaround until #5 will work out

@Schniz
Copy link
Owner Author

Schniz commented Feb 5, 2019

@elliottsj, can you please take a look at the fish section? 😄

Copy link
Contributor

@elliottsj elliottsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple corrections, passing --fish to the env command. Otherwise looks great!

.ci/install.sh Outdated Show resolved Hide resolved
.ci/install.sh Outdated Show resolved Hide resolved
@Schniz
Copy link
Owner Author

Schniz commented Feb 5, 2019

Cool! thanks! 😄

@Schniz Schniz force-pushed the add-install-script branch from b14a29c to a081ea0 Compare February 6, 2019 08:35
@Schniz
Copy link
Owner Author

Schniz commented Feb 7, 2019

Okay. I thought Fish doesn't provide the $SHELL env var, but it seems that it does. chsh -s $(which fish) fixed that, so I'm merging.

@Schniz Schniz merged commit 2904885 into master Feb 7, 2019
@Schniz Schniz deleted the add-install-script branch February 7, 2019 15:57
@Schniz Schniz added the PR: Documentation Some docs were added label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Documentation Some docs were added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants