Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v6.17.1 in partial_semver feature test #149

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Update to v6.17.1 in partial_semver feature test #149

merged 1 commit into from
Oct 8, 2019

Conversation

thomsj
Copy link
Contributor

@thomsj thomsj commented Oct 8, 2019

Update node 6 version to final/end-of-life version.

@thomsj
Update to v6.17.1 in partial_semver feature test
503a88c 
Update node 6 version to final/end-of-life version.
@Schniz Schniz added the PR: Internal An internal work has been made label Oct 8, 2019
Schniz
Schniz approved these changes Oct 8, 2019
View reviewed changes
Copy link
Owner

@Schniz Schniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks!

@Schniz Schniz merged commit ada519b into Schniz:master Oct 8, 2019
@thomsj
Copy link
Contributor Author

thomsj commented Oct 8, 2019

Do you think exit 1 should be added?

@Schniz
Copy link
Owner

Schniz commented Oct 8, 2019

@thomsj ah, yes!

@thomsj thomsj deleted the update-partial-semver branch October 9, 2019 20:17
@thomsj thomsj mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schniz Schniz Schniz approved these changes

Assignees
No one assigned
Labels
PR: Internal An internal work has been made
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomsj @Schniz