Add support for lts/*
#146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schniz
force-pushed
the
add-latest-lts-support
branch
from
6614fa2 to
3fa8126
Compare
Closed
Closed
thomsj
reviewed
Oct 9, 2019
| for test_file in $DIRECTORY/*/run.sh; do | ||
| for test_file in $DIRECTORY/latest-lts/run.sh; do |
There was a problem hiding this comment.
Was this a mistake, @Schniz?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #137.
Apparently, theres a
jsonfile in the Node dist that holds all the versions. This can be queried against to find the latest LTS, but can also be used to get any version we want. It can be cached locally and it should work better than traversing the HTML nodes as we do right now.This PR doesn't implement this but starting to use an uncached index.json. I believe that in a future PR I'll migrate everything to use that file!