Show error on kubernetes pages and kubernetes endpoint page. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2-master #96 +/- ##
============================================
+ Coverage 71.89% 71.9% +0.01%
============================================
Files 685 686 +1
Lines 29586 29632 +46
Branches 6789 6811 +22
============================================
+ Hits 21271 21308 +37
- Misses 8315 8324 +9 |
richard-cox
approved these changes
Nov 16, 2018
| const clearedEntity = Object.keys(entityState).reduce((prevEntityState, key) => { | ||
| return { | ||
| ...prevEntityState, | ||
| [key]: defaultPaginationEntityState |
There was a problem hiding this comment.
Regarding the previous code.. when we come back to this in the future we should just remove the entry instead of resetting.
- extend time for create service instance tests - extend time for some user tests (don't think this will help as much as SI) - ensure we don't fail when a service we don't want to be there doesn't
richard-cox
force-pushed
the
kube-endpoint-errors
branch
from
a60060d to
e514c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made new smaller effect that gets all error wrapper events and throws an internal error based on some new config.
I've also changed the routing path variable to be common across kubernetes and cf pages to make it easier for the page header to automatically pickup endpoint error states.