Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #45

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Various fixes #45

merged 1 commit into from
Oct 3, 2018

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Oct 3, 2018

Fixes:

  • Removes duplicate 'Share connection'
  • Hides Kubernetes in side nav when not connected
  • Fixes the metrics info to show K8S correctly
  • Fixes backend to return Prometheus Job for Kubernetes

@nwmac nwmac self-assigned this Oct 3, 2018
@nwmac nwmac added the ready for review Ready for review label Oct 3, 2018
@irfanhabib
Copy link

LGTM

@irfanhabib irfanhabib merged commit 023a6e7 into kube-integration Oct 3, 2018
@nwmac nwmac mentioned this pull request Apr 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nwmac nwmac

Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nwmac @irfanhabib