Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --phylanx:performance command line option #1323

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Adding --phylanx:performance command line option #1323

merged 1 commit into from
Aug 26, 2021

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Apr 5, 2021 •
edited by parsa
Loading

  • this option is implicitly available to all Phylanx executables; it can
    have an optional argument (i.e., --phylanx:performance=<filename>) that
    will use the argument as the destination filename (default: std::cout)

Fixes #1322.

@taless474, please check if this solves your issue.

@hkaiser hkaiser added this to the 0.0.1 milestone Apr 5, 2021
@hkaiser
Adding --phylanx:performance command line option
0c9248c 
- this option is implicitly available to all Phylanx executables, it can
  have an optional argument (i.e. --phylanx:performance=<filename>) that
  will use the argument as the destination file name (default: std::cout)
@taless474
Copy link
Contributor

I apologize for my really late response. Thank you for making this option.
I tried it for:

  • a non-distributed unit test, squeeze_operation_test
    On a file or on console it prints the column headers with no values (two new lines):
primitive_instance,display_name,count,time,eval_direct
  • the physl interpreter having these command arguments: --hpx:threads=1 C:\Users\Bita\Desktop\physl.txt --phylanx:performance
    with or without --print, it runs forever
    This is the code I intended to run:
cout(random(list(10,10), list("uniform_int", -3, 2)))
  • a distributed performance test, dist_cannon_4_test
    All 4 localities print this (one new line):
handle_late_commandline_options: command line processing: unrecognised option '--phylanx:performance'
primitive_instance,display_name,count,time,eval_direct

Did I need to add something to those tests?

@hkaiser
Copy link
Member Author

hkaiser commented May 31, 2021

@taless474 I'll have a look. Thanks!

@hkaiser hkaiser merged commit 0a7e5a0 into master Aug 26, 2021
@hkaiser hkaiser deleted the fixing_1322 branch August 26, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: primitives type: enhancement
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.

Add support for --performance option to any Phylanx program
2 participants
@hkaiser @taless474