Skip unusable javah tests #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update file headers Remove references to javah that are not used Black a couple of SConstcuts No functional changes - prep work for javah workarounds. Signed-off-by: Mats Wichmann <mats@linux.com>
For the three tests which fail, skip if the command finder (WhereIs), which is much less aggressive than the java_where_j* routines, doesn't find javah. Split the JAVAH test file into two files, so that the part which doesn't call javah can run even if the rest is skipped. Did the header cleanup and partial reformats on those. Leave a comment in the Repository/JavaH test, and do some reformatting there as well. Test needs rework, but for now doesn't fail so leave alone. Signed-off-by: Mats Wichmann <mats@linux.com>
mwichmann
added
the
testsuite
The previous sanity check was to see if the less-optimistic WhereIs could find javah, and skip if not, since java_where_javah looks many more places than SCons will actually look. This was insufficient - some openjdk packages don't clean up the alternatives link to javah even if a java version which doesn't have it becomes the selected version. Add a check on found paths to detect a mismatch. Signed-off-by: Mats Wichmann <mats@linux.com>
Signed-off-by: Mats Wichmann <mats@linux.com>
…this flag is specified to runtest.py and some tests are skipped. Otherwise assuming no failures will exit 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the three tests which fail, skip if the command finder (
WhereIs), which is much less aggressive than thejava_where_j*routines, doesn't findjavah.Split the
JAVAHtest file into two files, so that the part which doesn't call javah can run even if the rest is skipped.Header cleanup and partial Black reformats (test SConstructs) for Java tests.
Leave a comment in the
Repository/JavaHtest, and do some reformatting there as well. Test needs rework, but for now doesn't fail so leave alone.Remove references to javah that were not used
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)