#2845 Fixed message validation in event search #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limraj
reviewed
May 31, 2024
- Simplified validation for event id and max results checking if these two parameters are positive integers
- Separated search form validation function from search function - Changed messages display mechanism
Limraj
reviewed
Jun 21, 2024
WebContent/WEB-INF/jsp/events.jsp
Outdated
| } else { | ||
| doSearchOld(); | ||
| } | ||
| } | ||
|
|
||
| function validateSearchForm(){ | ||
| let messages = []; | ||
| if (!isValid(eventId.value)) { |
There was a problem hiding this comment.
Where do these eventId values come from?
Just use the same scheme as in the previous task #2919
- Changed validation mechanism
- Changed variables names for more appropriate
Limraj
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.