crypto-bigint: add initial proptests for equivalence with num-bigint #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
changed the title
tarcieri
commented
Jul 29, 2021
| @@ -44,7 +44,7 @@ impl<const LIMBS: usize> UInt<LIMBS> { | |||
|
|
|||
| /// Perform wrapping multiplication, discarding overflow. | |||
| pub const fn wrapping_mul(&self, rhs: &Self) -> Self { | |||
| self.mul_wide(rhs).0 | |||
| self.mul_wide(rhs).1 | |||
There was a problem hiding this comment.
As it were, these tests uncovered a bug
There was a problem hiding this comment.
We probably should cut a release with this fix and yank the versions with this bug. Even though I've seen this comment, I recently hit this bug and it took me some time to uncover this bug.
|
Ugh, looks like it's breaking due to |
|
Will need to factor it into a pseudo-crate for now to avoid breaking |
tarcieri
force-pushed
the
equivalence-proptests
branch
from
864d091 to
8aed700
Compare
Adds an initial set of property-based tests to check equivalence between `crypto_bigint::U256` and `num_bigint::BigUint`.
tarcieri
force-pushed
the
equivalence-proptests
branch
from
8aed700 to
cd19cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial set of property-based tests to check equivalence between
crypto_bigint::U256andnum_bigint::BigUint.I mostly want these for #561, but I figured I could push up an initial integration separately.