Line and block comments. #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Jul 1, 2021
|
I guess that I will send a pull requests against this to accept # as a line comment. |
|
I am not sure that we want to support both |
|
Hi, so the point of importing hex with comments is so that one can import output from other things to use as unit test data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #511
Closes #365 ('#' prefixed comments)
I kept the comment removal as a separate module so that the tests can be scoped to just removing commented parts of a string. There only needed to be a few documentation tests to show the macro was working as intended.
I decided to do
/* */style comments too because it was not much more work, but I can remove those states from the machine easily enough if you really do not want them.