Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print exception in a way that works outside exception context. #27

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

porridge
Copy link
Contributor

@porridge porridge commented Oct 26, 2022

Trying to print a traceback in journal_load_failed is too late, just prints None.

This can be reproduced by running addtrans from v0.3.5 on a file that does not exist. See the following screenshot:
Zrzut ekranu z 2022-10-28 18-27-33

@porridge porridge changed the title Call traceback.print_exc() while still in exception context. Print exception in a way that works outside exception context. Nov 8, 2022
@porridge
Copy link
Contributor Author

Anything left here for me to do so you can merge this @Rudd-O ?

Copy link
Owner

@Rudd-O Rudd-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't merge? Let me do so now.

@Rudd-O Rudd-O merged commit 6e8c5c9 into Rudd-O:master Nov 10, 2022
@porridge porridge deleted the fix-traceback branch November 11, 2022 06:57
@porridge
Copy link
Contributor Author

Thanks! Would you mind tagging a new release @Rudd-O ?

@Rudd-O
Copy link
Owner

Rudd-O commented Nov 14, 2022

Will do so.

@Rudd-O
Copy link
Owner

Rudd-O commented Nov 14, 2022

Done to both GH and PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants