Attempt to fix div.sheet-madness bug #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [this thread](https://app.roll20.net/forum/post/1691256/css-selector-not-being-processed#post-1691256), the first selector is not being processed. Because this sheet makes use of the unicode character Heavy Multiplication X (0x2716), and Roll20's CSS sanitation process throws out the entire thing if a backslash is detected, the file must be saved as Unicode. This means the file begins with the byte-order mark 0xFEFF. This commit is assuming that the BOM is being inserted into the style element right next to the ".charsheet" (or right next to the "div") at the start, which obviously does not match any element on the page, as there is neither an element `<0xFEFF class="charsheet">` nor an element `<0xFEFFdiv class="sheet-madness">`. As a result, a newline has been inserted between the BOM and "div" in the hope that the problem will not persist.
SteveKoontz
pushed a commit
that referenced
this pull request
Mar 9, 2015
Attempt to fix div.sheet-madness bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this
thread,
the first selector is not being processed. Because this sheet makes use
of the unicode character Heavy Multiplication X (0x2716), and Roll20's
CSS sanitation process throws out the entire thing if a backslash is
detected, the file must be saved as Unicode. This means the file begins
with the byte-order mark 0xFEFF.
This commit is assuming that the BOM is being inserted into the style
element right next to the ".charsheet" (or right next to the "div") at
the start, which obviously does not match any element on the page, as
there is neither an element
<0xFEFF class="charsheet">nor an element<0xFEFFdiv class="sheet-madness">. As a result, a newline has beeninserted between the BOM and "div" in the hope that the problem will not
persist.