-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Scenario: SNS_Secrets #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay so it has proper methods/routes.
- Still need to create walkthrough/README
- Added a detailed cheat sheet/walkthrough
Fixed formatting
Added sns_secrets scenario to the main readme
Added link to sns_secrets
andrew-aiken
reviewed
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario looks good
Just have one major question (in the api gateway section)
*Still have not looked over readme/cheat_sheet
- Fixed IAM to stop an unintentional exploit path - Removed extra things not needed in outputs from dev
- Fixed grammar in the main README for the sns_secrets scenario
- Fixed grammar on the sns_secrets scenario readme
- Added video walkthrough
andrew-aiken
reviewed
Jun 4, 2024
andrew-aiken
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Updated SNS Secrets Scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new scenario that showcases 2 new Pacu modules that were added to the latest release of Pacu. Additionally, I made a detailed walkthrough so that those new to AWS/CloudGoat will be able to follow along with the full scenario.