Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.6] Fix numeric union reopen on profile [MOD-7454] #4954

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Aug 22, 2024

Description

Backport of #4950 to 2.6.

GuyAv46 and others added 2 commits August 22, 2024 08:42
* add a failing test

* solve the bug

* added type assertion

(cherry picked from commit 1ea4537)
@GuyAv46 GuyAv46 added the bug label Aug 22, 2024
@GuyAv46 GuyAv46 requested a review from alonre24 August 22, 2024 06:48
@GuyAv46 GuyAv46 enabled auto-merge August 22, 2024 06:48
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.77%. Comparing base (61b060d) to head (cc212b5).
Report is 1 commits behind head on 2.6.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #4954      +/-   ##
==========================================
+ Coverage   83.74%   83.77%   +0.02%     
==========================================
  Files         178      178              
  Lines       31256    31259       +3     
==========================================
+ Hits        26175    26186      +11     
+ Misses       5081     5073       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuyAv46 GuyAv46 added this pull request to the merge queue Aug 22, 2024
Merged via the queue into 2.6 with commit 0ac8822 Aug 22, 2024
11 checks passed
@GuyAv46 GuyAv46 deleted the backport-4950-to-2.6 branch August 22, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants