Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: remove buffer/window with supplier & onExceptionResumeNext #6564

Merged
merged 1 commit into from
Jul 11, 2019
Merged

3.x: remove buffer/window with supplier & onExceptionResumeNext #6564

merged 1 commit into from
Jul 11, 2019

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Jul 8, 2019

This PR removes 3 kinds of operators that had no noticeable use bases or use cases on their own in the past years.

  • buffer(Supplier [, Supplier])
  • window(Supplier [, int])
  • onExceptionResumeNext(<source>)

Resolves #6554
Resolves #6555

@akarnokd akarnokd added this to the 3.0 milestone Jul 8, 2019
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #6564 into 3.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6564      +/-   ##
============================================
+ Coverage     98.19%   98.19%   +<.01%     
+ Complexity     6199     6181      -18     
============================================
  Files           682      678       -4     
  Lines         45461    44886     -575     
  Branches       6290     6212      -78     
============================================
- Hits          44640    44076     -564     
- Misses          268      274       +6     
+ Partials        553      536      -17
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <100%> (ø) 565 <0> (-5) ⬇️
...al/operators/observable/ObservableOnErrorNext.java 100% <100%> (ø) 2 <1> (ø) ⬇️
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 540 <0> (-5) ⬇️
...ternal/operators/flowable/FlowableOnErrorNext.java 100% <100%> (ø) 2 <1> (ø) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 88.8% <0%> (-5.23%) 2% <0%> (ø)
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-2.5%) 2% <0%> (ø)
...ava/io/reactivex/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-2.39%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelSortedJoin.java 92.7% <0%> (-2.19%) 2% <0%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71945f3...caeba3a. Read the comment docs.

@akarnokd akarnokd merged commit d35ac97 into ReactiveX:3.x Jul 11, 2019
@akarnokd akarnokd deleted the RemoveOps0708a branch July 11, 2019 06:34
@akarnokd akarnokd mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x Removal
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Remove exact buffer/window with Supplier<source>? Remove onExceptionResumeNext?
1 participant
@akarnokd