3.x rename on error resume next methods to disambiguate when calling from kotlin (#6551) #6556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ErrorResumeWith, removing unnecessary cast from null tests, and updating Observable.onErrorResumeWith's JavaDoc to reference correct parameter name, renamed test classes since the distinctions in their names are no longer necessary.
….onErrorResumeWith(MaybeSource), renamed some of the affected unit tests, and updated JavaDoc.
…ErrorResumeWith(Single), renamed an affected unit test, updated JavaDoc, and removed redundant casts.
…e<? extends T> to SingleSource<? extends T>
…able.onErrorResumeWith(Publisher), renaming some affected tests, deleted duplicated unit test that arose from being able to remove redundant casts, updated JavaDocs.
akarnokd
approved these changes
Jul 3, 2019
vanniktech
approved these changes
Jul 4, 2019
luis-cortes
deleted the
3.x-Rename-onErrorResumeNext-methods-to-disambiguate-when-calling-from-Kotlin-(#6551)
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6551
onErrorResumeNext(Source)toonErrorResumeWith(Source)forObservable,Maybe,Single, andFlowableSingle.onErrorResumeWithfromSingletoSingleSource