More robust detection of bzip2 magic number #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated via commit 2db0960 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 11 minutes and 35 seconds Time taken to run |
|
Not sure we really need the Besides that, LGTM |
ben-schwen
reviewed
Jul 23, 2024
yea for the problem as diagnosed it's kinda silly. but wanted to keep some examples close to OP's report, that way we're ironclad sure we've closed the issue & it'll stay closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6304
Also took the opportunity to factor out some helpers for easier maintenance/readability. That could be split to its own precursor PR if so desired.
We could extend
is_bzip()to also look for "raw pi" (as.raw(c(0x31, 0x41, 0x59, 0x26, 0x53, 0x59))) in the 5th-10th bytes, but skip that for now. The example seems pretty pathological already.Also, I don't think that any of our
test_R.utilstests have been checking the "infer from magic number" functionality fromfread(), so this PR also adds some nice regression coverage for this behavior.