Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a regression test for fixed dcast fun.aggregate issue #4251

Merged
merged 5 commits into from
May 13, 2021
Merged

add a regression test for fixed dcast fun.aggregate issue #4251

merged 5 commits into from
May 13, 2021
+10 −2

Conversation

MichaelChirico
Copy link
Member

Closes #2394

@mattdowle mattdowle added this to the 1.14.1 milestone May 13, 2021
@mattdowle mattdowle mentioned this pull request May 13, 2021
Closed
@codecov
Copy link

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #4251 (dd4b28d) into master (9a4ace1) will not change coverage.
The diff coverage is n/a.

❗ Current head dd4b28d differs from pull request most recent head e8f66ec. Consider uploading reports for the commit e8f66ec to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4251   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          75       75           
  Lines       14705    14705           
=======================================
  Hits        14627    14627           
  Misses         78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4ace1...e8f66ec. Read the comment docs.

@mattdowle mattdowle merged commit 334d51e into master May 13, 2021
@mattdowle mattdowle deleted the issue2394-test branch May 13, 2021 21:51
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Segfault in dcast because of type mismatch in fun.aggregate
3 participants
@MichaelChirico @mattdowle @jangorecki