Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev breaks revdeps NMdata and scoringutils #5075

Closed
mattdowle opened this issue Jul 16, 2021 · 1 comment
Closed

dev breaks revdeps NMdata and scoringutils #5075

mattdowle opened this issue Jul 16, 2021 · 1 comment
Milestone
1.15.0

Comments

@mattdowle
Copy link
Member

I reran with dev before #5053 was merged: they still fail so it's not due to that.
I reran with 1.14.0 and they both pass.
So it's something in dev but I'm not sure what. Need to debug each one.
They both have recent updates which may be why they didn't come up in the last revdep run.

 ERROR   :    2 : NMdata scoringutils 
 WARNING :    0 :  
 NOTE    :  359 
 OK      :  734 
 TOTAL   : 1095 / 1095 

NMdata_0.0.8.tar.gz
./NMdata.Rcheck/00check.log:* using log directory ‘/home/mdowle/build/revdeplib/NMdata.Rcheck’
./NMdata.Rcheck/00check.log:* using R version 4.1.0 (2021-05-18)
./NMdata.Rcheck/00check.log:* using platform: x86_64-pc-linux-gnu (64-bit)
./NMdata.Rcheck/00check.log:* using session charset: UTF-8
./NMdata.Rcheck/00check.log:* checking for file ‘NMdata/DESCRIPTION’ ... OK
./NMdata.Rcheck/00check.log:* checking extension type ... Package
./NMdata.Rcheck/00check.log:* this is package ‘NMdata’ version ‘0.0.8’
./NMdata.Rcheck/00check.log:* package encoding: UTF-8
./NMdata.Rcheck/00check.log:* checking package namespace information ... OK
./NMdata.Rcheck/00check.log:* checking package dependencies ... OK
./NMdata.Rcheck/00check.log:* checking if this is a source package ... OK
./NMdata.Rcheck/00check.log:* checking if there is a namespace ... OK
./NMdata.Rcheck/00check.log:* checking for executable files ... OK
./NMdata.Rcheck/00check.log:* checking for hidden files and directories ... OK
./NMdata.Rcheck/00check.log:* checking for portable file names ... OK
./NMdata.Rcheck/00check.log:* checking for sufficient/correct file permissions ... OK
./NMdata.Rcheck/00check.log:* checking whether package ‘NMdata’ can be installed ... OK
./NMdata.Rcheck/00check.log:* checking installed package size ... NOTE
./NMdata.Rcheck/00check.log:  installed size is  7.2Mb
./NMdata.Rcheck/00check.log:  sub-directories of 1Mb or more:
./NMdata.Rcheck/00check.log:    examples   5.8Mb
./NMdata.Rcheck/00check.log:* checking package directory ... OK
./NMdata.Rcheck/00check.log:* checking ‘build’ directory ... OK
./NMdata.Rcheck/00check.log:* checking DESCRIPTION meta-information ... OK
./NMdata.Rcheck/00check.log:* checking top-level files ... OK
./NMdata.Rcheck/00check.log:* checking for left-over files ... OK
./NMdata.Rcheck/00check.log:* checking index information ... OK
./NMdata.Rcheck/00check.log:* checking package subdirectories ... OK
./NMdata.Rcheck/00check.log:* checking R files for non-ASCII characters ... OK
./NMdata.Rcheck/00check.log:* checking R files for syntax errors ... OK
./NMdata.Rcheck/00check.log:* checking whether the package can be loaded ... OK
./NMdata.Rcheck/00check.log:* checking whether the package can be loaded with stated dependencies ... OK
./NMdata.Rcheck/00check.log:* checking whether the package can be unloaded cleanly ... OK
./NMdata.Rcheck/00check.log:* checking whether the namespace can be loaded with stated dependencies ... OK
./NMdata.Rcheck/00check.log:* checking whether the namespace can be unloaded cleanly ... OK
./NMdata.Rcheck/00check.log:* checking loading without being on the library search path ... OK
./NMdata.Rcheck/00check.log:* checking dependencies in R code ... OK
./NMdata.Rcheck/00check.log:* checking S3 generic/method consistency ... OK
./NMdata.Rcheck/00check.log:* checking replacement functions ... OK
./NMdata.Rcheck/00check.log:* checking foreign function calls ... OK
./NMdata.Rcheck/00check.log:* checking R code for possible problems ... OK
./NMdata.Rcheck/00check.log:* checking Rd files ... OK
./NMdata.Rcheck/00check.log:* checking Rd metadata ... OK
./NMdata.Rcheck/00check.log:* checking Rd cross-references ... OK
./NMdata.Rcheck/00check.log:* checking for missing documentation entries ... OK
./NMdata.Rcheck/00check.log:* checking for code/documentation mismatches ... OK
./NMdata.Rcheck/00check.log:* checking Rd \usage sections ... OK
./NMdata.Rcheck/00check.log:* checking Rd contents ... OK
./NMdata.Rcheck/00check.log:* checking for unstated dependencies in examples ... OK
./NMdata.Rcheck/00check.log:* checking installed files from ‘inst/doc’ ... OK
./NMdata.Rcheck/00check.log:* checking files in ‘vignettes’ ... OK
./NMdata.Rcheck/00check.log:* checking examples ... OK
./NMdata.Rcheck/00check.log:* checking for unstated dependencies in ‘tests’ ... OK
./NMdata.Rcheck/00check.log:* checking tests ... ERROR
./NMdata.Rcheck/00check.log:  Running ‘testthat.R’
./NMdata.Rcheck/00check.log:Running the tests in ‘tests/testthat.R’ failed.
./NMdata.Rcheck/00check.log:Last 13 lines of output:
./NMdata.Rcheck/00check.log:   2.   └─testthat::expect_known_value(..., update = update)
./NMdata.Rcheck/00check.log:  ── Failure (test_NMscanInput.R:148:5): CYCLE=DROP ──────────────────────────────
./NMdata.Rcheck/00check.log:  `nm1` has changed from known value recorded in 'testReference/NMscanInput_7.rds'.
./NMdata.Rcheck/00check.log:  Component "input.colnames": Attributes: < Names: 1 string mismatch >
./NMdata.Rcheck/00check.log:  Component "input.colnames": Attributes: < Length mismatch: comparison on first 2 components >
./NMdata.Rcheck/00check.log:  Component "input.colnames": Attributes: < Component 2: Attributes: < target is NULL, current is list > >
./NMdata.Rcheck/00check.log:  Component "input.colnames": Attributes: < Component 2: Numeric: lengths (24, 0) differ >
./NMdata.Rcheck/00check.log:  Backtrace:
./NMdata.Rcheck/00check.log:      █
./NMdata.Rcheck/00check.log:   1. └─testthat::expect_equal_to_reference(nm1, fileRef, version = 2) test_NMscanInput.R:148:4
./NMdata.Rcheck/00check.log:   2.   └─testthat::expect_known_value(..., update = update)
./NMdata.Rcheck/00check.log:  
./NMdata.Rcheck/00check.log:  [ FAIL 20 | WARN 0 | SKIP 0 | PASS 82 ]
./NMdata.Rcheck/00check.log:  Error: Test failures
./NMdata.Rcheck/00check.log:  Execution halted
./NMdata.Rcheck/00check.log:* checking for unstated dependencies in vignettes ... OK
./NMdata.Rcheck/00check.log:* checking package vignettes in ‘inst/doc’ ... OK
./NMdata.Rcheck/00check.log:* checking running R code from vignettes ... NONE
./NMdata.Rcheck/00check.log:  ‘DataCreate.Rmd’ using ‘UTF-8’... OK
./NMdata.Rcheck/00check.log:  ‘NMdata-FAQ.Rmd’ using ‘UTF-8’... OK
./NMdata.Rcheck/00check.log:  ‘NMscanData.Rmd’ using ‘UTF-8’... OK
./NMdata.Rcheck/00check.log:* checking re-building of vignette outputs ... OK
./NMdata.Rcheck/00check.log:* checking PDF version of manual ... OK
./NMdata.Rcheck/00check.log:* DONE
./NMdata.Rcheck/00check.log:Status: 1 ERROR, 1 NOTE


scoringutils_0.1.7.tar.gz
./scoringutils.Rcheck/00check.log:* using log directory ‘/home/mdowle/build/revdeplib/scoringutils.Rcheck’
./scoringutils.Rcheck/00check.log:* using R version 4.1.0 (2021-05-18)
./scoringutils.Rcheck/00check.log:* using platform: x86_64-pc-linux-gnu (64-bit)
./scoringutils.Rcheck/00check.log:* using session charset: UTF-8
./scoringutils.Rcheck/00check.log:* checking for file ‘scoringutils/DESCRIPTION’ ... OK
./scoringutils.Rcheck/00check.log:* this is package ‘scoringutils’ version ‘0.1.7’
./scoringutils.Rcheck/00check.log:* package encoding: UTF-8
./scoringutils.Rcheck/00check.log:* checking package namespace information ... OK
./scoringutils.Rcheck/00check.log:* checking package dependencies ... OK
./scoringutils.Rcheck/00check.log:* checking if this is a source package ... OK
./scoringutils.Rcheck/00check.log:* checking if there is a namespace ... OK
./scoringutils.Rcheck/00check.log:* checking for executable files ... OK
./scoringutils.Rcheck/00check.log:* checking for hidden files and directories ... OK
./scoringutils.Rcheck/00check.log:* checking for portable file names ... OK
./scoringutils.Rcheck/00check.log:* checking for sufficient/correct file permissions ... OK
./scoringutils.Rcheck/00check.log:* checking whether package ‘scoringutils’ can be installed ... OK
./scoringutils.Rcheck/00check.log:* checking installed package size ... OK
./scoringutils.Rcheck/00check.log:* checking package directory ... OK
./scoringutils.Rcheck/00check.log:* checking ‘build’ directory ... OK
./scoringutils.Rcheck/00check.log:* checking DESCRIPTION meta-information ... OK
./scoringutils.Rcheck/00check.log:* checking top-level files ... OK
./scoringutils.Rcheck/00check.log:* checking for left-over files ... OK
./scoringutils.Rcheck/00check.log:* checking index information ... OK
./scoringutils.Rcheck/00check.log:* checking package subdirectories ... OK
./scoringutils.Rcheck/00check.log:* checking R files for non-ASCII characters ... OK
./scoringutils.Rcheck/00check.log:* checking R files for syntax errors ... OK
./scoringutils.Rcheck/00check.log:* checking whether the package can be loaded ... OK
./scoringutils.Rcheck/00check.log:* checking whether the package can be loaded with stated dependencies ... OK
./scoringutils.Rcheck/00check.log:* checking whether the package can be unloaded cleanly ... OK
./scoringutils.Rcheck/00check.log:* checking whether the namespace can be loaded with stated dependencies ... OK
./scoringutils.Rcheck/00check.log:* checking whether the namespace can be unloaded cleanly ... OK
./scoringutils.Rcheck/00check.log:* checking loading without being on the library search path ... OK
./scoringutils.Rcheck/00check.log:* checking dependencies in R code ... NOTE
./scoringutils.Rcheck/00check.log:Namespace in Imports field not imported from: ‘graphics’
./scoringutils.Rcheck/00check.log:  All declared Imports should be used.
./scoringutils.Rcheck/00check.log:* checking S3 generic/method consistency ... OK
./scoringutils.Rcheck/00check.log:* checking replacement functions ... OK
./scoringutils.Rcheck/00check.log:* checking foreign function calls ... OK
./scoringutils.Rcheck/00check.log:* checking R code for possible problems ... OK
./scoringutils.Rcheck/00check.log:* checking Rd files ... OK
./scoringutils.Rcheck/00check.log:* checking Rd metadata ... OK
./scoringutils.Rcheck/00check.log:* checking Rd cross-references ... NOTE
./scoringutils.Rcheck/00check.log:Package unavailable to check Rd xrefs: ‘surveillance’
./scoringutils.Rcheck/00check.log:* checking for missing documentation entries ... OK
./scoringutils.Rcheck/00check.log:* checking for code/documentation mismatches ... OK
./scoringutils.Rcheck/00check.log:* checking Rd \usage sections ... OK
./scoringutils.Rcheck/00check.log:* checking Rd contents ... OK
./scoringutils.Rcheck/00check.log:* checking for unstated dependencies in examples ... OK
./scoringutils.Rcheck/00check.log:* checking contents of ‘data’ directory ... OK
./scoringutils.Rcheck/00check.log:* checking data for non-ASCII characters ... OK
./scoringutils.Rcheck/00check.log:* checking LazyData ... OK
./scoringutils.Rcheck/00check.log:* checking data for ASCII and uncompressed saves ... OK
./scoringutils.Rcheck/00check.log:* checking installed files from ‘inst/doc’ ... OK
./scoringutils.Rcheck/00check.log:* checking files in ‘vignettes’ ... OK
./scoringutils.Rcheck/00check.log:* checking examples ... OK
./scoringutils.Rcheck/00check.log:* checking for unstated dependencies in ‘tests’ ... OK
./scoringutils.Rcheck/00check.log:* checking tests ... ERROR
./scoringutils.Rcheck/00check.log:  Running ‘testthat.R’
./scoringutils.Rcheck/00check.log:Running the tests in ‘tests/testthat.R’ failed.
./scoringutils.Rcheck/00check.log:Complete output:
./scoringutils.Rcheck/00check.log:  > library(testthat)
./scoringutils.Rcheck/00check.log:  > library(scoringutils)
./scoringutils.Rcheck/00check.log:  Note: The definition of the weighted interval score has slightly changed in version 0.1.5. If you want to use the old definition, use the argument `count_median_twice = TRUE` in the function `eval_forecasts()`
./scoringutils.Rcheck/00check.log:  > 
./scoringutils.Rcheck/00check.log:  > test_check("scoringutils")
./scoringutils.Rcheck/00check.log:  ══ Failed tests ════════════════════════════════════════════════════════════════
./scoringutils.Rcheck/00check.log:  ── Failure (test-interval_score.R:117:3): wis works, 2 intervals and median ────
./scoringutils.Rcheck/00check.log:  eval$interval_score not identical to `expected`.
./scoringutils.Rcheck/00check.log:  Objects equal but not identical
./scoringutils.Rcheck/00check.log:  
./scoringutils.Rcheck/00check.log:  [ FAIL 1 | WARN 0 | SKIP 0 | PASS 51 ]
./scoringutils.Rcheck/00check.log:  Error: Test failures
./scoringutils.Rcheck/00check.log:  Execution halted
./scoringutils.Rcheck/00check.log:* checking for unstated dependencies in vignettes ... OK
./scoringutils.Rcheck/00check.log:* checking package vignettes in ‘inst/doc’ ... OK
./scoringutils.Rcheck/00check.log:* checking running R code from vignettes ... NONE
./scoringutils.Rcheck/00check.log:  ‘scoringutils.Rmd’ using ‘UTF-8’... OK
./scoringutils.Rcheck/00check.log:* checking re-building of vignette outputs ... OK
./scoringutils.Rcheck/00check.log:* checking PDF version of manual ... OK
./scoringutils.Rcheck/00check.log:* DONE
./scoringutils.Rcheck/00check.log:Status: 1 ERROR, 2 NOTEs
@mattdowle mattdowle added this to the 1.14.1 milestone Jul 16, 2021
@mattdowle
Copy link
Member Author

scoringutils looks to be resolved by its update to 0.1.7.2 on 07/21.

This was referenced Jul 26, 2021
Merged
Merged
@tdhock tdhock mentioned this issue Nov 27, 2022
Closed
@jangorecki jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@mattdowle @jangorecki