-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bad design link #4540
Comments
@coke I think that the Docs used to contain a lot of links to Sxx documents, and they have gradually been replaced. Is one of the utilities for testing the documents able to pick out any other |
The problem is, the link works, it just goes to a github repo front page now instead of the original deep link, so the test we have doesn't complain. Anything in
needs fixing to point to the new structure. |
@coke May be the following algorithm would work:
@coke let me know and I can try to do this. I could manage a single PR with all the changes to all the files, but I'm not sure I could programmatically create one PR for each file changed. The following files were reported by
|
sounds good! |
[gist of report with link checks](https://gist.github.com/finanalyst/47673157b55de202c62b612eaafe1d48#file-gistfile1-txt)
@coke Just committed first batch of changes. I had intended to raise a PR first for review. My bad. |
now working on those with internal links eg |
[gist of report with link checks](https://gist.github.com/finanalyst/c676034b4f09b0f7621b9d4ee4848955#file-report-changes-with-internal-targets-md) [gist of internal links that do not work](https://gist.github.com/finanalyst/8323598b46113a0c429bdf7cf0b41457#file-failing-internal-links-md)
We can just remove that paragraph. Or at least most of it.
…On Sun, Dec 29, 2024 at 10:09 AM Richard Hainsworth < ***@***.***> wrote:
@coke <https://github.com/coke> Not sure how to deal with this one:
../doc/Language/mop.rakudoc:181:L<design documents|https://design.raku.org/> are very light on details.
Its a one-off as there is not Sdd design document to fall back to.
@lizmat <https://github.com/lizmat> May be the document contents can be
changed to something more up to date?
—
Reply to this email directly, view it on GitHub
<#4540 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMIUIZKLZVH44BV6GWFFT2IAGCNAVCNFSM6AAAAABTFKJ53CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG42TGMJYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
[gist of report with link checks](https://gist.github.com/finanalyst/c676034b4f09b0f7621b9d4ee4848955#file-report-changes-with-internal-targets-md) [gist of internal links that do not work](https://gist.github.com/finanalyst/8323598b46113a0c429bdf7cf0b41457#file-failing-internal-links-md)
https://docs.raku.org/language/regexes#Quoted_lists_are_LTM_matches
links to
https://design.raku.org/S05.html#Longest-token_matching
but that's just a github repo at this point - not a 404 so it doesn't fail.
Ideally, remove the link and describe the strategy internally to the docs.
The text was updated successfully, but these errors were encountered: