feat: view source content in app #655
Conversation
|
@lawvs is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
lawvs
force-pushed
the
feat/source-view-poc
branch
from
71df955 to
b6f80a2
Compare
|
Excellent work!
|
lawvs
force-pushed
the
feat/source-view-poc
branch
3 times, most recently
from
0129bd9 to
badee90
Compare
| style={stableRenderStyle} | ||
| className="duration-200 ease-in-out animate-in fade-in slide-in-from-bottom-24 f-motion-reduce:fade-in-0 f-motion-reduce:slide-in-from-bottom-0" | ||
| key={entry.entries.id} | ||
| <div className="relative flex size-full flex-col overflow-hidden"> |
There was a problem hiding this comment.
Just wrap a new div here, try enabling "hide whitespace" to see the changes.
lawvs
force-pushed
the
feat/source-view-poc
branch
from
841054d to
1430941
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
That's great. But have you considered adding a shortcut to this feature? By the way, for the sake of UI consistency, we should use the Solid icon when the button is selected. |
Signed-off-by: Innei <i@innei.in>
|
And I've noticed a significant frame drop during the animation transition with the ViewSource open. Is there a way to optimize this. Perhaps content rendering should be avoided during the transition, and only displayed after it is completed. |
I have optimized the transition when viewing the source code, and the frame drop issue has been somewhat alleviated. Screen.Recording.2024-09-29.at.02.21.32.mov
Regarding the shortcut key, I think we can use cmd+b or ctrl+b (win). What do you think? |
After checking, I found that the shortcut cmd+B conflicts with the toggle feed sidebar, so it is not feasible. Additionally, assigning shortcuts without careful consideration of their functions is not a good practice. Perhaps we can consider it later. |
|
Nice work! |
Fix #247
This pull request introduces a new feature that allows users to view the source content in the follow app.
Warn banner for web
Loading and transition
Screen.Recording.2024-09-28.at.15.38.24.mov
Modal in social and video
Screen.Recording.2024-09-28.at.15.40.18.mov
In image view
Screen.Recording.2024-09-28.at.15.44.23.mov
Note: This is just a prototype PR designed to demonstrate the practicality and feasibility of this feature.Before proceeding with further enhancements, I need some guidance on the following points:1. Viewing the source in a modal is also a viable option. Should we adjust to view the source in a modal?2. Currently, the feature is triggered by right-clicking the "Open in browser" btn. This is not an ideal solution, but I think the toolbar in the top-right corner is already crowded. Where do you think would be a better place for this button?