Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand entry read history #377

Merged
merged 8 commits into from
Sep 14, 2024
Merged

feat: expand entry read history #377

merged 8 commits into from
Sep 14, 2024

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Sep 13, 2024

Copy link

linear bot commented Sep 13, 2024

Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2024 6:13am

@Innei
Copy link
Member

Innei commented Sep 13, 2024

I feel like a dropdown menu would be more appropriate here, using a modal would make it feel very cut off.

@hyoban
Copy link
Member Author

hyoban commented Sep 13, 2024

But the number of read history user IDs can be up to 100 now.

https://github.com/RSSNext/follow-server/commit/7930d7370b4a408ec1f5f56c2e45cecca8872350

Or do we revert it and keep it 20?

@Innei
Copy link
Member

Innei commented Sep 13, 2024

CleanShot 2024-09-13 at 4  49 32@2x

Just make it scrollable and infinite scrolling

@hyoban
Copy link
Member Author

hyoban commented Sep 14, 2024

I do not know why. When I use drawer for UserProfileModal, it will open and quickly dismiss.

@Innei
Copy link
Member

Innei commented Sep 14, 2024

I will fix that

@Innei
Copy link
Member

Innei commented Sep 14, 2024

@hyoban

There is no problem with increasing the number of history records on the server side.

On the front end, it doesn't make sense to get to 100 records directly. Because in many cases users don't click More to see more users, the conversion rate is very low.

So to reduce the size of the data transfer and the pressure on the database itself. We should remove the entryReadHistories datafill from the entry interface on the server side, and then do the data paging in entries/read-histories/{id}.

In other words, there should be no read-histories queries or data in entries?id= right now. Instead, the API interface is separated into two.

@hyoban
Copy link
Member Author

hyoban commented Sep 14, 2024

Got it, I'll take care of this part

Signed-off-by: Innei <i@innei.in>
@Innei
Copy link
Member

Innei commented Sep 14, 2024

I do not know why. When I use drawer for UserProfileModal, it will open and quickly dismiss.

@hyoban I fix this bug

Signed-off-by: Innei <i@innei.in>
@Innei
Copy link
Member

Innei commented Sep 14, 2024

@hyoban I'll merge it first, and then we can start a new branch to implement the above functionality.

@Innei Innei merged commit e7f923a into dev Sep 14, 2024
6 checks passed
@Innei Innei deleted the feat/expand-read-history branch September 14, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follower过多无法展开
2 participants