Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): improve border visibility for meta display #2138

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ktKongTong
Copy link
Contributor

Description

Fixed an issue where scrolling caused the header's bottom border to appear, leading to a slight 1px shift of its content.

No changes were made for mobile component since the element doesn't show after scrolling.

Before
header-before

After
header-after

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix(header): improve border visibility for meta display

Change Summary:
Refactored header styles to ensure proper border display when meta is shown.

Code Review:
No change requests necessary.

Copy link

vercel bot commented Dec 13, 2024

@ktKongTong is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@ktKongTong ktKongTong changed the title fix: entry-header move 1px while scroll fix: entry-header shift 1px on scroll Dec 13, 2024
@ktKongTong ktKongTong changed the title fix: entry-header shift 1px on scroll fix(header): improve border visibility for meta display Dec 13, 2024
Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Innei Innei merged commit 0505e3d into RSSNext:dev Dec 13, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants