fix: handle popstate for navigation in mobile entry content #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. We will review it promptly. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Suggested PR Title: Change Summary: Code Review: |
|
@CanglongCl is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
CanglongCl
changed the title
Innei
requested changes
Dec 7, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolved issue where back navigation to the pending view would not behave correctly after changing orientation in some device.
Before: after changing the orientation, the
BACKbutton is navigate to previous feeds, which is expected to navigate to all feeds view.Screen-2024-12-06-235533.mp4
After: now the back navigation will be force pushed to previous feed list.
Screen-2024-12-06-235449.mp4
For some iPad users, using Landscape orientation to browser the list and preview on right, while using Portrait orientation for reading provides excellent experience. This PR will improve experience in this situation.
PR Type
Linked Issues
Additional context
Changelog