Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve perform for feed column #1708

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: improve perform for feed column #1708

merged 1 commit into from
Nov 22, 2024

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Nov 22, 2024

Refactor components to enhance performance through memoization and improved state management.

Adjustments include changes to feed actions and modal handling, resulting in a more efficient rendering process.

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 7:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 7:53am

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: improve hooks and clean up feed actions

Change Summary:
This PR refactors various hooks in the renderer, notably enhancing useEntryActions and useFeedActions for better performance and readability. Significant changes include the use of useMemo to optimize action computation, removal of unnecessary parameters in some hooks, and cleanup of stale code, resulting in a streamlined codebase. Additionally, adjustments to UI interactions in the feed and wallet modules improve user experience.

Code Review:
No change requests necessary.

@lawvs lawvs requested a review from Innei November 22, 2024 07:58
@lawvs lawvs merged commit 1f349ed into dev Nov 22, 2024
9 of 10 checks passed
@lawvs lawvs deleted the fix/performance branch November 22, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Innei Innei Innei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawvs @Innei