Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read count #135

Merged
merged 1 commit into from
Jul 15, 2024
Merged

feat: read count #135

merged 1 commit into from
Jul 15, 2024

Conversation

songkeys
Copy link
Contributor

image

For this feature, optimistic update rendering is executed within the UI layer rather than the queries layer due to the utilization of the read data mutation in certain instances via react query and in others through the patch method within the data store. This disparity significantly complicates the endeavor of maintaining data consistency. It may be necessary to address this issue at a later time.

The original approach undertaken was outlined as follows for renference:

image

@songkeys songkeys requested a review from Innei July 15, 2024 15:43
Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 3:43pm

@DIYgod DIYgod merged commit c8dbd59 into main Jul 15, 2024
6 checks passed
@DIYgod DIYgod deleted the feat/read-count branch July 15, 2024 15:50
@songkeys songkeys restored the feat/read-count branch July 16, 2024 13:26
@songkeys songkeys deleted the feat/read-count branch July 16, 2024 13:27
Copy link

sentry-io bot commented Jul 16, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'every') / View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants