fix(app): throw error popup when close window #1144
Conversation
Once the window is destroyed, none of the window's methods can be used (except for `destroy` and `isDestroyed`). The reason that destroy can be called multiple times is that Electron performs a check: https://github.com/electron/electron/blob/57920e7747f09627f99ed5c27457339aa7c3fe57/shell/common/gin_helper/destroyable.cc#L28 The ability to call isDestroyed is because no window methods are used during the implementation process: https://github.com/electron/electron/blob/57920e7747f09627f99ed5c27457339aa7c3fe57/shell/common/gin_helper/destroyable.cc#L48-L49 Signed-off-by: Kevin Cui <bh@bugs.cc>
|
@BlackHole1 is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
BlackHole1
changed the title
|
This issue occurs intermittently, and the fundamental reason for this problem is that there are other places that are destroying the window. The code is as follows: Follow/apps/main/src/updater/index.ts Lines 16 to 19 in 8193cbc Lines 177 to 180 in 8193cbc Both pieces of code could trigger this issue, but the first one is more likely to do so. The second one is less frequent because it also listens to the The first one triggers very frequently because it completely does not rely on any Electron events when destroying the window, leading to a scenario of "true concurrent execution." |
|
Thank you so much for your help!!! |
Description
Once the window is destroyed, none of the window's methods can be used (except for
destroyandisDestroyed).Linked Issues
Fix: #1127 #1092
Additional context
The reason that destroy can be called multiple times is that Electron performs a check: https://github.com/electron/electron/blob/57920e7747f09627f99ed5c27457339aa7c3fe57/shell/common/gin_helper/destroyable.cc#L28
The ability to call isDestroyed is because no window methods are used during the implementation process: https://github.com/electron/electron/blob/57920e7747f09627f99ed5c27457339aa7c3fe57/shell/common/gin_helper/destroyable.cc#L48-L49