fix: margin between the top bar and the content #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cuikaipeng is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
|
Wow, thank you so much for the PR. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue #1049 mentions the problem of the top bar being obscured.
This PR #1051 addresses that issue.
But I noticed there are still some problems on the Video page.
The margins are too narrow.
Here's how it looked before.
I tried to find the cause of the above issue. I checked the commit history, and in this commit 847c317#diff-8edd1371c19527656614803122cca80cb2fde924536821a4f868bbf727a55157, the "mb-2" style was removed, which led to the issue with the top bar being obscured. I think the removal of "mb-2" here, is to handle the situation where there need a TimelineTabs component.
I think the approach to solving this issue should be to determine whether "mb-2" is needed based on the type of displayed content.
So I submitted this PR.
Linked Issues
Additional context