fix: should remove app skeleton in error page

Signed-off-by: Innei <tukon479@gmail.com>
RSSNext · Nov 6, 2024 · 4073632 · 4073632
1 parent 1739208
commit 4073632
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/apps/renderer/src/App.tsx b/apps/renderer/src/App.tsx
@@ -53,15 +53,15 @@ const AppLayer = () => {
   const appIsReady = useAppIsReady()
 
   useEffect(() => {
+    document.querySelector("#app-skeleton")?.remove()
+
     const doneTime = Math.trunc(performance.now())
     window.analytics?.capture("ui_render_init", {
       time: doneTime,
     })
     appLog("App is ready", `${doneTime}ms`)
 
     applyAfterReadyCallbacks()
-
-    document.querySelector("#app-skeleton")?.remove()
   }, [appIsReady])
 
   return appIsReady ? <Outlet /> : <AppSkeleton />

diff --git a/apps/renderer/src/components/common/ErrorElement.tsx b/apps/renderer/src/components/common/ErrorElement.tsx
@@ -20,6 +20,10 @@ export function ErrorElement() {
       : JSON.stringify(error)
   const stack = error instanceof Error ? error.stack : null
 
+  useEffect(() => {
+    document.querySelector("#app-skeleton")?.remove()
+  }, [])
+
   useEffect(() => {
     console.error("Error handled by React Router default ErrorBoundary:", error)