fix: app icon incorrect in Windows Control Panel #899
Conversation
|
@BlackHole1 is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
Close: https://discord.com/channels/1243823539426033696/1294232031148118088 Signed-off-by: Kevin Cui <bh@bugs.cc>
BlackHole1
force-pushed
the
fix-win-icon
branch
from
a2ba9d0 to
fa6bbfc
Compare
| @@ -154,6 +154,7 @@ const config: ForgeConfig = { | |||
| new MakerSquirrel({ | |||
| name: "Follow", | |||
| setupIcon: "resources/icon.ico", | |||
| iconUrl: "https://app.follow.is/favicon.ico", | |||
There was a problem hiding this comment.
Ref: electron/windows-installer#151
The configuration options for @electron-forge/maker-squirrel can be found at https://github.com/electron/windows-installer.
Previously, the nupkg restricted iconUrl to be an http(s) address. The nupkg team claimed to have fixed this issue in 2019, but according to community reports, it doesn't work on Windows 10.
Testing shows that using: file://${__dirname}/resources/icon.ico can work (the downside might be that it doesn't display correctly on Windows 10).
There was a problem hiding this comment.
According to the latest nupkg documentation, iconUrl has been deprecated. The current recommendation is to use <icon>, and this tag supports local image resources. Unfortunately, the built-in nupkg version in windows-installer is 2.8.5, and this tag is only supported from nupkg@5.3.0. Additionally, windows-installer does not provide any method to specify the path of nupkg.
There was a problem hiding this comment.
BTW. Why not use electron-builder? Forge currently only supports MSI/Squirrel on Windows. However, electron-builder supports NSIS. Using NSIS won't have this issue,
Description
Now:
Before:
Linked Issues
Additional context
Close: https://discord.com/channels/1243823539426033696/1294232031148118088