Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/adafruit-metro-m4-express: Minor improvements #21041

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 26, 2024

Contribution description

This PR contains two commits with one minor improvement each:

  • The I2C and UART Arduino Mapping is provided
  • The TTY detection now also can detect the board when the bootloader is running (which registers using the bootloader's USB vendor ID and model, rather than the RIOT variant)

Testing procedure

Both already tested using #21029

It would be possible to do so now by:

  • Adding the peripheral self-test shield and run the corresponding test (but UART and SPI are mutually exclusive due to lack of time-sharing for SERCOMs)
  • double pressing the reset button (to enter bootloader mode) and run make BOARD=adafruit-metro-m4-express MOST_RECENT_PORT=1 -C examples/default flash. This does now work, but fails in master

Issues/PRs references

Split out of #21029

@maribu maribu added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 26, 2024
@github-actions github-actions bot added the Area: boards Area: Board ports label Nov 26, 2024
The M4 Express does now have an I2C and an UART compatible with Arduino
Shields, so we can expose them.
Also detect TTY of bootloader with `MOST_RECENT_PORT=1`.
@maribu maribu force-pushed the boards/adafruit-metro-m4/improvements branch from 3fba155 to 567d044 Compare November 26, 2024 12:33
@riot-ci
Copy link

riot-ci commented Nov 26, 2024

Murdock results

✔️ PASSED

567d044 boards/adafruit-metro-m4-express: improve TTY detection

Success Failures Total Runtime
561 0 561 04m:24s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 26, 2024
Merged via the queue into RIOT-OS:master with commit 1f624ad Nov 26, 2024
26 checks passed
@maribu maribu deleted the boards/adafruit-metro-m4/improvements branch November 26, 2024 20:10
@maribu
Copy link
Member Author

maribu commented Nov 26, 2024

Thx :)

@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants