Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/nucleo-l432kc: enable CAN support #20845

Merged
merged 1 commit into from
Oct 7, 2024
Merged

boards/nucleo-l432kc: enable CAN support #20845

merged 1 commit into from
Oct 7, 2024

Conversation

donsez
Copy link
Contributor

@donsez donsez commented Aug 29, 2024 •
edited by benpicco
Loading

Contribution description

This PR adds CAN support to the nucleo-l432kcboard (see issue #20837) .

Testing procedure

The testing procedure requires one Nucleo L432KC board, one Nucleo board having CAN interface (F446RE for instance) and 2 CAN drivers (such as ST L9616).

cd tests/sys/conn_can
make BOARD=nucleo-l432kc flash term

Nucleo 1 (receiver)

init 0
set_mode 0 0
test_can recv 1 0 10000000 100 500

Nucleo 2 (sender)

init 0
set_mode 0 0
test_can send 0 100 01 02

Issues/PRs references

fixes #20837.

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Aug 29, 2024
@benpicco
Copy link
Contributor

Thank you for the contribution!
Can you please prefix the commit message with the subsystem, so in this case

boards/nucleo-l432kc: add configuration CAN peripheral

and please remove boards/nucleo-l432kc/Makefile.features.uncrustify

@benpicco
Copy link
Contributor

Please squash your commits - you can do so by running

git rebase -i HEAD~2

@donsez donsez force-pushed the pr/add_can_to_board_nucleo-l432kc branch from e6cd228 to 56c14ee Compare August 30, 2024 10:10
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 2, 2024
@riot-ci
Copy link

riot-ci commented Sep 2, 2024 •
edited
Loading

Murdock results

✔️ PASSED

84ec09f boards/nucleo-l432kc: add configuration CAN peripheral

Success Failures Total Runtime
10196 0 10197 15m:07s

Artifacts

@benpicco
Copy link
Contributor

benpicco commented Oct 7, 2024

Please squash again!

@donsez
boards/nucleo-l432kc: add configuration CAN peripheral
84ec09f 
Signed-off-by: Didier DONSEZ <didier.donsez@gmail.com>
@donsez donsez force-pushed the pr/add_can_to_board_nucleo-l432kc branch from 5218861 to 84ec09f Compare October 7, 2024 15:35
benpicco
benpicco approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@benpicco benpicco enabled auto-merge October 7, 2024 15:37
@benpicco benpicco changed the title add can support to nucleo-l432kc board (issue #20837) boards/nucleo-l432kc: enable CAN support Oct 7, 2024
@benpicco benpicco added this pull request to the merge queue Oct 7, 2024
Merged via the queue into RIOT-OS:master with commit 0e20bfd Oct 7, 2024
26 checks passed
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add CAN support to Nucleo L432KC (Nucleo 32)
3 participants
@donsez @benpicco @riot-ci