-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.editorconfig: add EditorConfig #20746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except the Makefile size maybe ?
.editorconfig
Outdated
[{Makefile*,*.mk}] | ||
indent_style = tab | ||
indent_size = 4 | ||
tab_size = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have a tab_size policy of 2 for Makefile ?
This adds an [EditorConfig][homepage] file in the root of the repo. Most editors support it [natively][native-support] or via a [plugin][plugin-support]. This is particularly useful for occasional contributors, who with this no longer need to configure the editor to properly show and format source code. [homepage]: https://editorconfig.org/ [native-support]: https://editorconfig.org/#pre-installed [plugin-support]: https://editorconfig.org/#download
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK.
Let's hope it helps.
Contribution description
This adds an EditorConfig file in the root of the repo. Most editors support it natively or via a plugin.
This is particularly useful for occasional contributors, who with this no longer need to configure the editor to properly show and format source code.
Testing procedure
Open/edit a source file in the PR branch with one of the supported editors. The format should match the coding convention out of the box.
Issues/PRs references
None