Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/hashes: change SHA2 PAD type to const #20729

Merged
merged 1 commit into from
Jun 6, 2024
Merged

sys/hashes: change SHA2 PAD type to const #20729

merged 1 commit into from
Jun 6, 2024

Conversation

LP-HAW
Copy link
Contributor

@LP-HAW LP-HAW commented Jun 5, 2024

Contribution description

This PR changes the SHA2 PAD type to a const type, saving 64 bytes of RAM.

Testing procedure

cd tests/unittests
make tests-hashes
make term

Issues/PRs references

None

@github-actions github-actions bot added the Area: sys Area: System label Jun 5, 2024
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 6, 2024
mguetschow
mguetschow approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@riot-ci
Copy link

riot-ci commented Jun 6, 2024

Murdock results

✔️ PASSED

7efb4d9 sys/hashes: change SHA2 PAD type to const

Success Failures Total Runtime
10161 0 10161 17m:46s

Artifacts

@mguetschow mguetschow added this pull request to the merge queue Jun 6, 2024
Merged via the queue into RIOT-OS:master with commit dd6051c Jun 6, 2024
27 checks passed
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

Assignees
No one assigned
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LP-HAW @riot-ci @mguetschow