Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nanocoap_sock: add nanocoap_get_blockwise_to_buf() #20690

Merged
merged 1 commit into from
May 28, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

Just like nanocoap_get_blockwise_url_to_buf(), but with a socket instead of a URL.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System labels May 23, 2024
@benpicco benpicco force-pushed the nanocoap_get_blockwise_to_buf branch from 7d6c572 to c5cfecb Compare May 23, 2024 14:11
@benpicco benpicco requested a review from fabian18 May 27, 2024 08:51
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 27, 2024
@riot-ci
Copy link

riot-ci commented May 27, 2024

Murdock results

✔️ PASSED

c5cfecb nanocoap_sock: add nanocoap_get_blockwise_to_buf()

Success Failures Total Runtime
10143 0 10143 17m:34s

Artifacts

Copy link
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the implementation of nanocoap_get_blockwise_url_to_buf(), the implementation of nanocoap_get_blockwise_to_buf() is straight forward.

@benpicco benpicco added this pull request to the merge queue May 27, 2024
Merged via the queue into RIOT-OS:master with commit e62c25a May 28, 2024
27 checks passed
@benpicco benpicco deleted the nanocoap_get_blockwise_to_buf branch May 28, 2024 07:48
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants