ci: ensure "xxx succeeded" properly fail #20288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: CI
|
The last fixup commit shows this is now failling this PR b/c of the fixup commit. |
|
(now that I'm looking at this, the tools-build-success has the same issue) |
maribu
reviewed
Jan 23, 2024
.github/workflows/check-commits.yml
Outdated
| with: | ||
| jobs: ${{ toJSON(needs) }} | ||
|
|
||
| ## adding some fixup |
There was a problem hiding this comment.
that's from the test fixup commit (which makes this PR fail)
|
Sorry for the late addition, I've added a similar fix for the tools build test, plus another test commit. |
|
tools-buildtest failed (as expected due to the test commit that broke edbg) |
kaspar030
force-pushed
the
fix_check_commits
branch
from
b2e83de to
5a16b63
Compare
kaspar030
changed the title
|
Sorry again, but now this is ready. |
maribu
approved these changes
Jan 23, 2024
benpicco
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Fixes #20287 and a similar issue for the "tools-build succeeded" ci job.
Testing procedure
Issues/PRs references