Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/gnrc_border_router: enable setting ZEP topology #20006

Merged
merged 1 commit into from
Nov 1, 2023
Merged

examples/gnrc_border_router: enable setting ZEP topology #20006

merged 1 commit into from
Nov 1, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 20, 2023 •
edited
Loading

Contribution description

When simulating a IEEE 802.15.4 network, it is handy being able to specify a topoloy.

Testing procedure

make -C examples/gnrc_border_router ZEP_TOPO_FILE=network.topo ZEP_MONITOR=1 term

will make use of the file network.topo and create a wpan0 with which the traffic on the simulated wireless network can be monitored with Wireshark.

network.topo
A	B
B	C
C	D

To start the wireless nodes, run 3 instances of examples/gnrc_networking with USE_ZEP=1.

Issues/PRs references

@github-actions github-actions bot added Area: tools Area: Supplementary tools Area: examples Area: Example Applications labels Oct 20, 2023
@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 20, 2023
@riot-ci
Copy link

riot-ci commented Oct 26, 2023

Murdock results

✔️ PASSED

2f2dcb7 examples/gnrc_border_router: enable setting ZEP topology

Success Failures Total Runtime
17 0 17 01m:15s

Artifacts

@benpicco benpicco requested review from miri64, kfessel and maribu October 30, 2023 14:04
kfessel
kfessel reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me.

I did a short test and it seemed to work.
a borde_router with the example config network.topo and 3 x gnrc_networking:
1st could ping 2nd but not 3rd.
3rd could ping 2nd but not 1st.

Just delaying my approve for a day if someone else has an issue with this change.

@benpicco
Copy link
Contributor Author

I think there are not that many users of the ZEP radio simulation unfortunately, maybe I should try to popularize it more.

@benpicco
Copy link
Contributor Author

benpicco commented Nov 1, 2023

bors merge

bors bot added a commit that referenced this pull request Nov 1, 2023
@bors @benpicco @kfessel
Merge #20006 #20033
36160d9 
20006: examples/gnrc_border_router: enable setting ZEP topology r=benpicco a=benpicco



20033: driver/mtd: mtd_init add documentation for return value r=benpicco a=kfessel



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
Co-authored-by: Karl Fessel <karl.fessel@ml-pa.com>
@bors bors
Copy link
Contributor

bors bot commented Nov 1, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@benpicco
Copy link
Contributor Author

benpicco commented Nov 1, 2023

bors merge

@bors bors
Copy link
Contributor

bors bot commented Nov 1, 2023

Already running a review

@bors bors
Copy link
Contributor

bors bot commented Nov 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 436a4ec into RIOT-OS:master Nov 1, 2023
3 checks passed
@benpicco benpicco deleted the examples/gnrc_border_router-zep branch November 1, 2023 10:27
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

@miri64 miri64 Awaiting requested review from miri64

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: examples Area: Example Applications Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @kfessel @MrKevinWeiss