drivers/mtd_spi_nor: fix init when only ztimer_msec is used #19908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
added
Type: bug
benpicco
force-pushed
the
mtd_spi_nor-ztimer_msec
branch
from
f68cde4 to
6e290fb
Compare
benpicco
added
Area: drivers
|
Should we not add an #else so in case neither xtimer nor ztimer m/usec are used it outputs an error (or at least a warning of some sorts)? |
|
If the driver needs either ztimer [ms/us] or xtimer, why is there no such logic in the Makefile.dep? |
|
The idea is to have a polling fallback for e.g. use in |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
If only
ztimer_msec(and notztimer_usec) is used, themtd_spi_nor_power()function will not execute thewait_chip_wake_updelay.This causes
mtd_init()to fail (and in a very annoying way: adding debug prints can cause enough of a delay that the init then works again).Testing procedure
tests/drivers/mtd_rawshould work with onlyztimer_msecinstead ofztimer_usec.Issues/PRs references
wouldn't have happened if we had #19719