drivers/ws281x: add RMT hardware support for ESP32x SoCs #19424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner,
fjmolinas and
maribu
as code owners
github-actions
bot
added
Area: boards
maribu
reviewed
Mar 26, 2023
gschorcht
force-pushed
the
drivers/ws281x_esp32_use_rmt
branch
from
a73d494 to
862e0c7
Compare
maribu
approved these changes
Mar 28, 2023
maribu
added
the
CI: ready for build
gschorcht
force-pushed
the
drivers/ws281x_esp32_use_rmt
branch
from
862e0c7 to
0224941
Compare
gschorcht
added
the
Type: enhancement
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 29, 2023
19424: drivers/ws281x: add RMT hardware support for ESP32x SoCs r=maribu a=gschorcht ### Contribution description This PR provides support for ESP32x RMT that is used to generate WS2812B signals. All ESP32x SoCs have a [Remote Control Peripheral (RMT)](https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32/api-reference/peripherals/rmt.html) that can be used to generate digital waveforms, such as NEC remote control signals or WS2812B RGB LED signals. Each RMT peripheral has either 4 or 8 channels. Some ESP32x SoCs support configuring the clock sources used for each channel separately, while other ESP32x SoCs can only use a single clock source for all channels. The advantages using the RMT are that the CPU is not busy when generating the WS218x signal and the phase times are accurate to nanoseconds. The disadvantage is that the configuration of the RMT is so complex due to its flexibility that the [ESP-IDF high-level driver for RMT](https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32c3/api-reference/peripherals/rmt.html) is used.This requires about 6 kBytes more ROM, about 3 kBytes more IRAM, and 88 bytes more RAM. Therefore, either the RMT hardware implementation (module `ws2812x_esp32_hw`) as well as the bit-banging software implementation (module `ws2812x_esp32_hw`) can be used. RMT hardware implementation (module `ws2812x_esp32_hw`) is used by default. Timing with hardware implementation:  ### Testing procedure `tests/driver_ws281x` should still work, for example: ``` CFLAGS='-DWS281X_PARAM_PIN=GPIO45 -DWS281X_PARAM_NUMOF=47' BOARD=esp32s3-devkit make -j8 -C tests/driver_ws281x flash ``` Test Output: https://user-images.githubusercontent.com/31932013/227791753-e6d2924e-3364-4387-870f-a56d3a9a8a80.mp4 ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
|
Build failed: |
|
🙄 I had to add |
|
bors retry |
|
👎 Rejected by PR status |
|
Ah, squashing is still missing |
fixup! tests/driver_ws281x: add ESP32x CI boards to test ws281x_esp32_sw
gschorcht
force-pushed
the
drivers/ws281x_esp32_use_rmt
branch
from
05f78ff to
be03323
Compare
Yes, by intention to show the last changes. |
|
bors retry |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors retry |
|
Build succeeded: |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides support for ESP32x RMT that is used to generate WS2812B signals.
All ESP32x SoCs have a Remote Control Peripheral (RMT) that can be used to generate digital waveforms, such as NEC remote control signals or WS2812B RGB LED signals. Each RMT peripheral has either 4 or 8 channels. Some ESP32x SoCs support configuring the clock sources used for each channel separately, while other ESP32x SoCs can only use a single clock source for all channels.
The advantages using the RMT are that the CPU is not busy when generating the WS218x signal and the phase times are accurate to nanoseconds. The disadvantage is that the configuration of the RMT is so complex due to its flexibility that the ESP-IDF high-level driver for RMT is used.This requires about 6 kBytes more ROM, about 3 kBytes more IRAM, and 88 bytes more RAM.
Therefore, either the RMT hardware implementation (module
ws2812x_esp32_hw) as well as the bit-banging software implementation (modulews2812x_esp32_hw) can be used. RMT hardware implementation (modulews2812x_esp32_hw) is used by default.Timing with hardware implementation:
Testing procedure
tests/driver_ws281xshould still work, for example:Test Output:
https://user-images.githubusercontent.com/31932013/227791753-e6d2924e-3364-4387-870f-a56d3a9a8a80.mp4
Issues/PRs references