Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtd: add fast path to mtd_write_page() #19252

Merged
merged 1 commit into from
Feb 8, 2023
Merged

mtd: add fast path to mtd_write_page() #19252

merged 1 commit into from
Feb 8, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 6, 2023

Contribution description

If we overwrite a whole sector, don't perform a read-modify-write cycle.

Testing procedure

Issues/PRs references

@benpicco
mtd: add fast path to mtd_write_page()
4447613 
If we overwrite a whole sector, don't perform a read-modify-write cycle.
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Feb 6, 2023
@benpicco benpicco requested a review from dylad February 6, 2023 14:48
@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer labels Feb 6, 2023
@benpicco benpicco mentioned this pull request Feb 6, 2023
Merged
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 6, 2023
@riot-ci
Copy link

riot-ci commented Feb 6, 2023 •
edited
Loading

Murdock results

✔️ PASSED

4447613 mtd: add fast path to mtd_write_page()

Success Failures Total Runtime
6851 0 6851 09m:49s

Artifacts

@dylad
Copy link
Member

dylad commented Feb 7, 2023

The idea makes a lot of sense and PR looks good !
I can give it a try tonight.

dylad
dylad approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@dylad dylad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@dylad
Copy link
Member

dylad commented Feb 7, 2023

bors merge

bors bot added a commit that referenced this pull request Feb 7, 2023
@bors @benpicco
Merge #19252
d5b6900 
19252: mtd: add fast path to mtd_write_page() r=dylad a=benpicco




Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

Build failed:

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 7, 2023
@benpicco
Copy link
Contributor Author

benpicco commented Feb 7, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 8, 2023

Build succeeded:

@bors bors bot merged commit f22ce15 into RIOT-OS:master Feb 8, 2023
@benpicco benpicco deleted the mtd_write_page-fast branch February 8, 2023 08:03
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylad dylad dylad approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @dylad @MrKevinWeiss