Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/tinydtls: drop libc_gettimeofday dependency #19247

Merged
merged 2 commits into from
Feb 28, 2023
Merged

pkg/tinydtls: drop libc_gettimeofday dependency #19247

merged 2 commits into from
Feb 28, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 5, 2023 •
edited
Loading

Contribution description

gettimeofday() (via time()) is only used to print timestamps in the debug output.
We don't need this, use our own debug functions without the expensive timestamp.

With this, we can drop the requirement to include libc_gettimeofday.

Testing procedure

before

Code should still compile

   text	   data	    bss	    dec	    hex	filename
 123068	    384	  24920	 148372	  24394	/home/benpicco/dev/RIOT/examples/dtls-sock/bin/openmote-b/dtls_sock.elf

with this patch

   text	   data	    bss	    dec	    hex	filename
 107756	    272	  24776	 132804	  206c4	/home/benpicco/dev/RIOT/examples/dtls-sock/bin/openmote-b/dtls_sock.elf

Issues/PRs references

upstream PR eclipse-tinydtls/tinydtls#187

@github-actions github-actions bot added the Area: pkg Area: External package ports label Feb 5, 2023
@benpicco benpicco force-pushed the pkg/tinydtls-gettimeofday branch from 50622a5 to 5c81e28 Compare February 5, 2023 22:29
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 5, 2023
@riot-ci
Copy link

riot-ci commented Feb 5, 2023 •
edited
Loading

Murdock results

✔️ PASSED

ff0b979 pkg/tinydtls: drop libc_gettimeofday

Success Failures Total Runtime
6864 0 6865 08m:20s

Artifacts

@benpicco benpicco force-pushed the pkg/tinydtls-gettimeofday branch from 5c81e28 to ff0b979 Compare February 25, 2023 13:57
@benpicco
Copy link
Contributor Author

Dropped the patch to tinydtls as it has been merged upstream.

kfessel
kfessel approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@kfessel kfessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@benpicco
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Feb 27, 2023
@bors @benpicco
Merge #17612 #19247
d530014 
17612: pkg: add FlashDB r=benpicco a=benpicco



19247: pkg/tinydtls: drop libc_gettimeofday dependency r=benpicco a=benpicco



Co-authored-by: Benjamin Valentin <benpicco@beuth-hochschule.de>
Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented Feb 27, 2023

Build failed (retrying...):

@benpicco
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 28, 2023

Already running a review

@bors
Copy link
Contributor

bors bot commented Feb 28, 2023

Build succeeded:

@bors bors bot merged commit 800ec56 into RIOT-OS:master Feb 28, 2023
@benpicco benpicco deleted the pkg/tinydtls-gettimeofday branch February 28, 2023 06:35
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfessel kfessel kfessel approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@chrysn chrysn Awaiting requested review from chrysn

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@maribu maribu Awaiting requested review from maribu

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @kfessel @MrKevinWeiss