rust: Use stable Rust [backport 2022.10] #19058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Area: doc
Murdock results✔️ PASSED ece93b8 doc/rust: Nightly is not needed any more
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
chrysn
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
This does unblock the removal of nightly from CI, but seeing how fast I am these days, that might be overtaken by 2023.01 anyway.
Still, it's a valid backport (which might be appreciated especially by those building stable releases directly from distro compilers and not through CI).
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=maribu a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=maribu a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
|
bors cancel |
|
Canceled. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=miri64 a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #18839
Contribution description
Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable.
Testing procedure
Note that these will not pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).Issues/PRs references
A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: