core/lib: define MAYBE_UNUSED #18884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area: core
jue89
previously requested changes
Nov 11, 2022
kfessel
force-pushed
the
p-macro-maybe-unused
branch
from
7f8e3bb to
4d43fb4
Compare
|
You may rebase on master ;-) |
kfessel
force-pushed
the
p-macro-maybe-unused
branch
from
4d43fb4 to
b4feefa
Compare
benpicco
approved these changes
Nov 18, 2022
benpicco
added
the
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are static functions and variables that may be unused if certain modules are used or not used.
Instead of adding a guard around these marking them as "maybe unused" is much clearer C23 seems to add a stadat attribute system where [[maybe_unused]] would be that mark
Contribution description
this adds a
MAYBE_UNUSEDdefine that uses the badly name__attribute((unused))__to mark suchmaybe unusedcasesTesting procedure
read
Issues/PRs references
this contains #18882