rust: Use stable Rust #18839
Merged
rust: Use stable Rust #18839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area: doc
chrysn
added
the
State: waiting for CI update
1 task
chrysn
added
the
CI: ready for build
Murdock results✔️ PASSED 7583626 doc/rust: Nightly is not needed any more
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
chrysn
removed
the
CI: ready for build
chrysn
added
CI: ready for build
This is possible starting with Rust 1.65.
chrysn
force-pushed
the
rust-use-stable
branch
from
7cbb022 to
7583626
Compare
|
Fixed one more obsolete comment and punctuation error in the docs (insta-squashed). This should now be ready. (If we were in a hurry with getting rid of nightly, it might even be proposed for backporting into any 2022.10.1, but given that nightly just "sits there" after this commit, I don't think we are in a hurry) |
|
We could still backport it to the 2022.10 branch. I'm not qualified to truly understand the consequences, but to me it looks mostly like a convenience update. I'd say we can make an exception and backport it (especially on the grounds that I do not think that switching from a nightly toolchain to a stable toolchain branch is scary). But IMO we need to have some solid reasoning for why this cannot just wait for the next release. Would it fix any issues? |
|
Convenience and speedier removal of nightlies from CI is all there is to it. It solves no concrete problem of the shipped release.
|
|
Did you say this speeds up the CI times? We need to backport this!!!!!one one eleven |
|
The speedup is only in procedures: If this is backported, it'll take us one fewer release to achieve full nightly-freeness through the lockstepping between main git and the CI image. I don't expect any change in build times through the process, except if you count image obtaining times, which will be a few percent faster after RIOT-OS/riotdocker#214. But anyway, it could need an ACK fish fish before it is backported (or, rather not) |
maribu
approved these changes
Nov 24, 2022
|
Let's backport this :) |
4 tasks
|
Backport provided in #19058 |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=maribu a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=maribu a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=miri64 a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
that referenced
this pull request
Jan 12, 2023
19058: rust: Use stable Rust [backport 2022.10] r=miri64 a=maribu # Backport of #18839 ### Contribution description Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable. ### Testing procedure * Green CI with tests enabled * Look at changed documentation ([rendered](https://ci.riot-os.org/results/2923b30a4ba04dbface1ed38fb6aae12/doc-preview/using-rust.html#toolchain)) <del>Note that these will *not* pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).</del> ### Issues/PRs references A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: * [x] CI rebuilds riotdocker -- no PR, then stable=1.65 * [ ] Use stable in examples -- this PR, then examples use stable * [ ] CI removes nightly and makes stable the default -- RIOT-OS/riotdocker#214, then default=stable * [ ] Use the new default to simplify makefiles -- #18840 Co-authored-by: chrysn <chrysn@fsfe.org>
bors bot
added a commit
to RIOT-OS/riotdocker
that referenced
this pull request
Oct 13, 2023
214: rust: Only install stable toolchain r=chrysn a=chrysn Closes: #208 As of Rust 1.65, there is no need for nightly versions of Rust for RIOT any more. Currently, this will likely (i.e. unless the nightly selection script happens to manage the case of no nightlies by assigning stable instead) not build, and depends on RIOT-OS/RIOT#18839 which switches away from nightlies. (See there for an overview of all lockstepping involved) Co-authored-by: chrysn <chrysn@fsfe.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Since Rust 1.65, we don't depend on anything nightly any more. This changes the examples and documentation to use stable.
Testing procedure
Note that these will not pass yet: This needs a CI update (no PR associated: Any CI image built from now on will do).Issues/PRs references
A follow-up will simplify things a bit further, but that will depend on CI to have made stable the default, which is a later step in what is a bit of a lock-step game: