Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/arduino_sdi_12: bump version, fix patches #18796

Merged
merged 1 commit into from
Oct 25, 2022
Merged

pkg/arduino_sdi_12: bump version, fix patches #18796

merged 1 commit into from
Oct 25, 2022

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 25, 2022 •
edited
Loading

Contribution description

Mostly doc changes since the last commit hash, patches now apply without the 3-way merge.

Testing procedure

Issues/PRs references

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 25, 2022
@github-actions github-actions bot added the Area: pkg Area: External package ports label Oct 25, 2022
@jue89 jue89 self-requested a review October 25, 2022 11:11
jue89
jue89 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jue89 jue89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Murdock is happy. So am I.

@jue89
Copy link
Contributor

jue89 commented Oct 25, 2022

I guess ci-prod needs another trigger. Is there a way to do it with retriggering Murdock with another 2 hours CI run?

@benpicco benpicco enabled auto-merge October 25, 2022 12:08
@kaspar030
Copy link
Contributor

I guess ci-prod needs another trigger. Is there a way to do it with retriggering Murdock with another 2 hours CI run?

disable compilation ...

@kaspar030
Copy link
Contributor

(I confirm it was green on ci.riot-os.org)

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 25, 2022
@riot-ci
Copy link

riot-ci commented Oct 25, 2022

Murdock results

✔️ PASSED

980eb89 pkg/arduino_sdi_12: bump version, fix patches

Success Failures Total Runtime
1 0 1 01m:15s

Artifacts

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

@benpicco benpicco merged commit 39fe035 into RIOT-OS:master Oct 25, 2022
@benpicco benpicco deleted the pkg/arduino_sdi_12-fix branch October 25, 2022 12:38
@kfessel
Copy link
Contributor

kfessel commented Oct 27, 2022

see #18810 we need a backport of this

@benpicco benpicco mentioned this pull request Oct 27, 2022
Merged
@benpicco benpicco removed the CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs label Oct 27, 2022
@kfessel kfessel mentioned this pull request Oct 27, 2022
Closed
@kaspar030 kaspar030 added this to the Release 2023.01 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jue89 jue89 jue89 approved these changes

Assignees
No one assigned
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.01
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @jue89 @kaspar030 @riot-ci @kfessel