Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update showcases with a new site #6859

Merged
merged 3 commits into from
Sep 5, 2024
Merged

docs: update showcases with a new site #6859

merged 3 commits into from
Sep 5, 2024

Conversation

EvilSpartans
Copy link
Contributor

@EvilSpartans EvilSpartans commented Sep 4, 2024 •
edited
Loading

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

I created a new app using Qwik, and I wanted to share it with the community. The app is available at https://qwikpdf.alexismoren.fr/. On PageSpeed, the app has achieved a score of 100, which showcases its performance capabilities. This PR is to present the app as a demonstration of what can be achieved with Qwik.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

Capture d’écran 2024-09-04 143339
Capture d’écran 2024-09-04 143402
qwikpdf

@EvilSpartans
Update pages.json
570ae39 
I would like to add my new app created with Qwik : 
https://qwikpdf.alexismoren.fr/

I can see on page speed a score of 100
@EvilSpartans EvilSpartans requested a review from a team as a code owner September 4, 2024 12:34
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 78164cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gioboa
gioboa previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me. Thanks @EvilSpartans

@gioboa gioboa changed the title Update pages.json docs: update showcases with a new site Sep 4, 2024
@gioboa gioboa enabled auto-merge (squash) September 4, 2024 16:12
@gioboa
Copy link
Member

gioboa commented Sep 4, 2024

@EvilSpartans you need to run pnpm fmt from the root and build.showcase from the docs folder. Thanks

auto-merge was automatically disabled September 5, 2024 20:08

Head branch was pushed to by a user without write access

@EvilSpartans EvilSpartans requested a review from a team as a code owner September 5, 2024 20:08
gioboa
gioboa approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @EvilSpartans

@gioboa gioboa enabled auto-merge (squash) September 5, 2024 20:16
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 5, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6859

npm i https://pkg.pr.new/@builder.io/qwik-city@6859

npm i https://pkg.pr.new/eslint-plugin-qwik@6859

npm i https://pkg.pr.new/create-qwik@6859

commit: 3694e26

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 3694e26

@gioboa gioboa merged commit 5b1b3eb into QwikDev:main Sep 5, 2024
13 checks passed
wmertens pushed a commit that referenced this pull request Sep 24, 2024
@EvilSpartans @wmertens
docs: update showcases with a new site (#6859)
8fce46a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvilSpartans @gioboa