Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SEO audit): 100% for mobile and desktop device #1953

Merged
merged 4 commits into from
Nov 2, 2022
Merged

fix(SEO audit): 100% for mobile and desktop device #1953

merged 4 commits into from
Nov 2, 2022

Conversation

vanvuongngo
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Fix SEO audit with chrome lighthouse test for mobile and desktop devices...


Before - 83% coverage:
Bildschirm­foto 2022-11-02 um 01 48 58

After - 100% coverage for mobile and desktop devices:
Bildschirm­foto 2022-11-02 um 02 17 29

Use cases and why

    1. increase core web vitals for SEO ranking

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Nov 2, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vanvuongngo vanvuongngo changed the title fix: SEO audit - 100% for mobile and desktop device fix(SEO audit): 100% for mobile and desktop device Nov 2, 2022
@manucorporat manucorporat merged commit cf626bf into QwikDev:main Nov 2, 2022
@manucorporat
Copy link
Contributor

Thank you so much for the improvement!

@vanvuongngo
Copy link
Contributor Author

Thanks for your instant review and I like these kind of Spirit :)

@vanvuongngo vanvuongngo deleted the fix/seo-audit-100 branch November 2, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants