feat(sass support): added support for .sass and .scss files #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I also need suggestion for the tests. |
Qwik already supports css files and css modules. Vite out of the box supports sass and scss files along with their module counterparts. This change enables the usage of SASS files and SASS modules. fix #986
|
Lint fails, might need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Qwik already supports css files and css modules. Vite out of the box
supports sass and scss files along with their module counterparts. This
change enables the usage of SASS files and SASS modules.
Use cases and why
.scssand.sassfiles even though correctly processed by Vite, are never properly exposed. Even though class names are properly created bycss-modulesthrough*.module.scssfiles, the actual stylesheets are unavailable to the components. This change let Qwik properly utilise styles transpiled by Vite.Checklist: