Fix/store obj #1232
Merged
Fix/store obj #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samijaber
commented
Sep 14, 2022
| } | ||
| } | ||
|
|
||
| if (isObject(obj)) { |
There was a problem hiding this comment.
we need to check the ojb after obj = obj.mut to make sure the value given to getProxyTarget is actually a valid object, and non-null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Honestly not sure what I'm looking at, but looks like @manucorporat 's changes in https://github.com/BuilderIO/qwik/pull/1217/files#diff-c80d393c4d0acda1ba573e20ff62b3bc96a4169298f7d1af7898ccd8fb60638a stopped checking that the mutated
objis still a validobjectbefore callinggetProxyTarget. So now we sometime providenulltogetProxyTarget, causing crashes.