Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(docs): integrate Qwik SDK to homepage using ?render=sdk (#1220)" #1230

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

adamdbradley
Copy link
Contributor

No description provided.

@gitguardian
Copy link

gitguardian bot commented Sep 13, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
2584471 Generic High Entropy Secret b9b14ca packages/docs/src/routes/index.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b9b14ca
Status: ✅  Deploy successful!
Preview URL: https://903295bc.qwik-docs.pages.dev
Branch Preview URL: https://revert-sdk.qwik-docs.pages.dev

View logs

@adamdbradley adamdbradley enabled auto-merge (squash) September 13, 2022 15:56
@adamdbradley adamdbradley merged commit 0a9cfad into main Sep 13, 2022
@adamdbradley adamdbradley deleted the revert-sdk branch September 13, 2022 16:05
mhevery added a commit to mhevery/qwik that referenced this pull request Sep 13, 2022
mhevery added a commit that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant